Skip to content

Color "Proceed with installation?" prompt in Edera installer script#21

Merged
jspeed-meyers merged 2 commits intomainfrom
copilot/color-proceed-statements-installer
Apr 27, 2026
Merged

Color "Proceed with installation?" prompt in Edera installer script#21
jspeed-meyers merged 2 commits intomainfrom
copilot/color-proceed-statements-installer

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 24, 2026

The install.sh installer script was missing the cyan prompt coloring applied to confirmation prompts in ec2-setup.sh, leaving "Proceed with installation?" unstyled and easy to miss.

Changes

  • install.shsetup_colors(): Added CYAN=$'\033[1;36m' (and CYAN='' for non-TTY fallback), matching ec2-setup.sh.
  • install.shconfirm(): Wrapped the prompt text with ${CYAN}...${RESET} on both the TTY and piped-stdin code paths.
# Before
printf "Proceed with installation? [y/N] "

# After
printf "${CYAN}Proceed with installation?${RESET} [y/N] "

…setup.sh

Agent-Logs-Url: https://github.com/edera-dev/learn/sessions/a5325afd-b463-46b7-8077-9f4f36f65557

Co-authored-by: jspeed-meyers <54914994+jspeed-meyers@users.noreply.github.com>
Copilot AI changed the title [WIP] Add color to 'Proceed ...' statements in Edera installer script Color "Proceed with installation?" prompt in Edera installer script Apr 24, 2026
Copilot AI requested a review from jspeed-meyers April 24, 2026 21:16
@jspeed-meyers jspeed-meyers marked this pull request as ready for review April 24, 2026 21:26
@jspeed-meyers jspeed-meyers requested review from Copilot and removed request for jspeed-meyers April 24, 2026 21:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Edera “on-installer” install.sh script to visually highlight the interactive confirmation prompt by applying the same cyan coloring used in the EC2 setup scripts, making the “Proceed with installation?” prompt harder to miss during runs.

Changes:

  • Add CYAN to setup_colors() with an empty-string fallback for non-TTY output.
  • Colorize the “Proceed with installation?” prompt in both interactive-stdin and piped-stdin (/dev/tty) confirmation paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jspeed-meyers jspeed-meyers added the enhancement New feature or request label Apr 27, 2026
@jspeed-meyers jspeed-meyers merged commit 99654e3 into main Apr 27, 2026
4 checks passed
@jspeed-meyers jspeed-meyers deleted the copilot/color-proceed-statements-installer branch April 27, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants